Rocksolid Light

Welcome to novaBBS (click a section below)

mail  files  register  newsreader  groups  login

Message-ID:  

Got Mole problems? Call Avogadro at 6.02 x 10^23.

devel / comp.os.msdos.djgpp / Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI register and doesn't save it

SubjectAuthor
* Fwd: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SIOzkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]
`* Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SIStefan Ring
 `* Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SIOzkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]
  `* Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI register and doesnEli Zaretskii (eliz@gnu.org) [via djgpp@delorie.com]
   `- Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SIOzkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]

1
Fwd: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI register and doesn't save it

<CAA2C=vCKayVtwbC7xaPtcfZ2a6PDPLAa8K2diCRN52=yi9R_Og@mail.gmail.com>

  copy mid

https://www.novabbs.com/devel/article-flat.php?id=207&group=comp.os.msdos.djgpp#207

  copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!weretis.net!feeder6.news.weretis.net!news.misty.com!border-2.nntp.ord.giganews.com!border-1.nntp.ord.giganews.com!nntp.giganews.com!Xl.tags.giganews.com!local-2.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Tue, 02 Aug 2022 07:07:13 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:from:to:cc;
bh=4/wKXmkmgTzlWxBsTJPTwjBizIykz6sFaVVIosdHHDM=;
b=TdFgG+AXNzuyKihdCwKscuQt7AZD5SP1wuR/dWE+OtnuI7BM2LbikG9na5B//FJP6d
35hSvkrD3B+IaEeM6dOhphlQbXUNabQLxWmYvefTNGy8FwetqgJjHb7lJVKxTpUFrWX+
sl+m3vfKAf+ci7gIbbeFKA4u8fIiggVlacnw6usw+lSEPczlKjNwk5oB+P0R6JQjOtcM
qVsTinRRPDULUB5ZrAaVuiW3CuMHxNM48bzHqppWNSal2pGIr3xbsccI/gta6pLdtqjb
p74K4OET2X/GhOVipsBz17fR/B1giwu/+iN2MM62yiro4aRx5Nf6ejTa0t5HTosy3/1S
D/1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:x-gm-message-state:from:to:cc;
bh=4/wKXmkmgTzlWxBsTJPTwjBizIykz6sFaVVIosdHHDM=;
b=7JRzy9z7jggXCHBIVnW6TOwPjVzTPw2Hnt0gaFdwfi+6cYybXqQFQBbhKTiVyFPIbL
SUBtNfC1HtxQrH+IeqzKGO1sIAvWreIzIgne6/HWDwQnc9R0J0idF4Mupcf7o46TosJu
WdrzyMSO30djC9k10bTlRpror7aSBwTO6w7kqrzRtBa+tUD7qvVL9MyIFg6OTCoRnnSb
Rh0W2oQakyxMOoBQ9P9DD20Ehx97m4qEwb/sKp+Kk2ybxP7zIFf5Q9N5J1nP1beXOcZ3
8jLj+Aerw20gaO5Z0AdiUu0RtIZhv8W6SAgMLG8PTb7meKF0FfCApTLPsnwmY/rvsJWd
CXWg==
X-Gm-Message-State: ACgBeo2TIStSCZeUj7QT4f4pBTIYr30mz/50dL6I1TNWNt1h8s5LDs7j
wb7FssQbSyFDUUGcNHzm6NLZlK/AHZblvjiJLMpkqNfDlk8=
X-Google-Smtp-Source: AA6agR4AGykRriXRQi365xX9PLbN6svXE3MhGtR103HNSlKKaJqfxPjVVNWYiCKifBFdviZDGuGmxbqG/RrQfmFGhBo=
X-Received: by 2002:adf:a1d2:0:b0:21e:bc22:f550 with SMTP id
v18-20020adfa1d2000000b0021ebc22f550mr12519477wrv.399.1659424059543; Tue, 02
Aug 2022 00:07:39 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <414f3e66.a1.182565154ec.Coremail.lostxwind@163.com>
References: <3c11b033.75.182562fe32f.Coremail.lostxwind@163.com> <414f3e66.a1.182565154ec.Coremail.lostxwind@163.com>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Tue, 2 Aug 2022 10:07:39 +0300
Message-ID: <CAA2C=vCKayVtwbC7xaPtcfZ2a6PDPLAa8K2diCRN52=yi9R_Og@mail.gmail.com>
Subject: Fwd: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI
register and doesn't save it
To: djgpp@delorie.com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 48
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-siDOfRX+wqGMfsIruwhefP122sJDqGIRw8CZgknLPBaKzI3FuzJqN6hWIBhZ7QhJFeQuXuaeqtW3kDK!olIZGPh3sGNj0mPCn4v+CmjgtukHATgB6VPDgH9EY4kY0Rv6KfjNFO2XCNLJjhaVhcOFYiSWRTuD!A4yPXYbbG2VmgMJr+pI54rGYUD4=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
 by: Ozkan Sezer (sezeroz - Tue, 2 Aug 2022 07:07 UTC

The 'djgpp' mailing list is more active - forwarding this to it:

---------- Forwarded message ----------
From: "lostxwind (lostxwind@163.com) [via djgpp-workers@delorie.com]"
<djgpp-workers@delorie.com>
Date: Mon, 1 Aug 2022 06:12:26 +0800 (CST)
Subject: Re:BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI
register and doesn't save it
To: djgpp-workers@delorie.com

Hi,

I was trying to issue a bug report on delorie official site
(https://www.delorie.com/djgpp/bugs/create.cgi) but failed as the
database is closed. So I tried to contact you through email.

BUGREPROT:

BACKGROUND:
___dpmi_get_raw_mode_switch_addr() is needed to switch modes for some
reason, instead of the __dpmi_simulate_real_mode_* class.
SYMPTOM:
Random crashes involving switch between real(/v86) mode and protected mode.
REASON:
I found variables or function parameters corrupted after calling
___dpmi_get_raw_mode_switch_addr().
After reading the source code, I believe that the implementation of
___dpmi_get_raw_mode_switch_addr() has missed a single line that saves
the ESI register.
src\libc\dpmi\api\d0306.S, line 2-line 4.

code before fix:
#define USE_EBX
#define USE_EDI
#include "dpmidefs.h"

possible fix:
#define USE_EBX
#define USE_EDI
#define USE_ESI
#include "dpmidefs.h"

Current workaround without bugfix:
Write a alternative implementation;
Or wrap the function call with asm that pushl/popl %esi.

Thanks,
crazii

Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI register and doesn't save it

<83b98192-9ce6-495d-8eaf-9c4e6906cb5dn@googlegroups.com>

  copy mid

https://www.novabbs.com/devel/article-flat.php?id=208&group=comp.os.msdos.djgpp#208

  copy link   Newsgroups: comp.os.msdos.djgpp
X-Received: by 2002:ac8:598e:0:b0:33c:9c91:2f0e with SMTP id e14-20020ac8598e000000b0033c9c912f0emr10037292qte.213.1659801140752;
Sat, 06 Aug 2022 08:52:20 -0700 (PDT)
X-Received: by 2002:a05:690c:807:b0:322:be87:7926 with SMTP id
bx7-20020a05690c080700b00322be877926mr10878305ywb.510.1659801140457; Sat, 06
Aug 2022 08:52:20 -0700 (PDT)
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!feed1.usenet.blueworldhosting.com!peer01.iad!feed-me.highwinds-media.com!news.highwinds-media.com!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.os.msdos.djgpp
Date: Sat, 6 Aug 2022 08:52:20 -0700 (PDT)
In-Reply-To: <CAA2C=vCKayVtwbC7xaPtcfZ2a6PDPLAa8K2diCRN52=yi9R_Og@mail.gmail.com>
Injection-Info: google-groups.googlegroups.com; posting-host=81.217.199.198; posting-account=RR3OeQoAAACYgn23XqTski3oGOFlt-O1
NNTP-Posting-Host: 81.217.199.198
References: <3c11b033.75.182562fe32f.Coremail.lostxwind@163.com>
<414f3e66.a1.182565154ec.Coremail.lostxwind@163.com> <CAA2C=vCKayVtwbC7xaPtcfZ2a6PDPLAa8K2diCRN52=yi9R_Og@mail.gmail.com>
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <83b98192-9ce6-495d-8eaf-9c4e6906cb5dn@googlegroups.com>
Subject: Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI
register and doesn't save it
From: stefan...@gmail.com (Stefan Ring)
Injection-Date: Sat, 06 Aug 2022 15:52:20 +0000
Content-Type: text/plain; charset="UTF-8"
X-Received-Bytes: 1649
 by: Stefan Ring - Sat, 6 Aug 2022 15:52 UTC

> src\libc\dpmi\api\d0306.S, line 2-line 4.
>
> code before fix:
> #define USE_EBX
> #define USE_EDI
> #include "dpmidefs.h"
>
> possible fix:
> #define USE_EBX
> #define USE_EDI
> #define USE_ESI
> #include "dpmidefs.h"

Yes, looks very reasonable, given that the DPMI call explicitly changes (e)si.

Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI register and doesn't save it

<CAA2C=vBOy1Yj26JqRHMNjHqv9DE19wuTDZOA0Rq7s0B1xeoq0w@mail.gmail.com>

  copy mid

https://www.novabbs.com/devel/article-flat.php?id=209&group=comp.os.msdos.djgpp#209

  copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!weretis.net!feeder6.news.weretis.net!news.misty.com!border-2.nntp.ord.giganews.com!border-1.nntp.ord.giganews.com!nntp.giganews.com!Xl.tags.giganews.com!local-2.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Sun, 07 Aug 2022 04:16:56 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:from:to:cc;
bh=UAQTrkW/3uONz2wCYGrpKTFqhE3g4SrhQiMseyXM78U=;
b=dsHNBz0hO+cJjmJczZx2EeDRdV5ADNdZv/FsyROvGaLrZ0novGj5SMvzpRwiWvNZas
81TmUhPDEhsWxOaSHddLFaVeccPQKQkNTHMj0FdLfxnA116lV4vuhfpZC86cMXoEBqtm
FcLs8JkGI24N/z9jfW8emkZbhtTpOVGJhSyjbz4eqqmqsZATx+I+aZzCy8VFJaJ4hRJo
t8xcITxQCcRn6DetmOzbZ3G8n5voZnVex7IuRuFmlh/2+Xnxzp8YTcdCKjW/h0BfLi12
8YJTGlF6DnhHc7RplqtzpKAPLg24qP2nfnST1EYV8DdKEMRW3tPKSQAH/HU2fjv9iQ1R
EfbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:x-gm-message-state:from:to:cc;
bh=UAQTrkW/3uONz2wCYGrpKTFqhE3g4SrhQiMseyXM78U=;
b=l8rzNt4eZYhQ/AqPyNXhbklyT0EbdT7pdqitG5RlHijg2hY93fcwKom3oeIkkFoy7W
IH/dmJvN7w2Yeb7RLzRQRPwjMKX9FpvQcgLXzT07zGHIDxVp67NlptYQHUndS3A3b4h9
aoUQPft52d2zf47783HUDRQKBLeCciOT2KJ8bC4qqP8mK5SiE7Wks3KJ1LsftJd0CkaI
jjdVNJSEeJ14X5ie5CUclgbHmfQSFofQQflzm0Gx/eb+TBi6oNckdwFhS90z2aOuni/D
CZxfcd0CYXk4LLjMupUKV49CrsQszkjBN5we+Atm4aVsgTzDECF2QXho0QSZOkbyyj1P
n/jQ==
X-Gm-Message-State: ACgBeo3xUQ9M/Xl7B6LRTFmgIU+7pmG2feHZ4K6CcdKO+d4yLrDnOLrI
Yt/1Is9ZqTdv7gspdIjWaT5yzkcDVfHh5e9NWurkr+QRjSM=
X-Google-Smtp-Source: AA6agR7RgYm0WBPGaGPkK7TlJXaVV/DO2Gw5/QwMYFyzQA2SHZ1voWE78tSH2sF89yWh18Ixobv+Nt3y5Gz+y6OLzsI=
X-Received: by 2002:a7b:cc18:0:b0:3a3:64c3:71fc with SMTP id
f24-20020a7bcc18000000b003a364c371fcmr13653593wmh.185.1659845662808; Sat, 06
Aug 2022 21:14:22 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <83b98192-9ce6-495d-8eaf-9c4e6906cb5dn@googlegroups.com>
References: <3c11b033.75.182562fe32f.Coremail.lostxwind@163.com>
<414f3e66.a1.182565154ec.Coremail.lostxwind@163.com> <CAA2C=vCKayVtwbC7xaPtcfZ2a6PDPLAa8K2diCRN52=yi9R_Og@mail.gmail.com>
<83b98192-9ce6-495d-8eaf-9c4e6906cb5dn@googlegroups.com>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Sun, 7 Aug 2022 07:14:22 +0300
Message-ID: <CAA2C=vBOy1Yj26JqRHMNjHqv9DE19wuTDZOA0Rq7s0B1xeoq0w@mail.gmail.com>
Subject: Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI
register and doesn't save it
To: djgpp@delorie.com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 40
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-DFYUoOvjd/z1ovILWQO2qNmIoFkz08qi1wzWHK/ixFfDKvwfTDSdDKp7DmySMsvtJUf2vZYURMOXomm!FU/fTY8cq424e8R1jKChwATZOk/E1atbzNKFCD1SnqUKYBgRkzjDwNJgWzb1s/WrW97IMMroewUc!s2QCtsv0KuHeiiupxNVcKs3ZfUU=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
 by: Ozkan Sezer (sezeroz - Sun, 7 Aug 2022 04:14 UTC

On 8/6/22, Stefan Ring (stefanrin@gmail.com) [via djgpp@delorie.com]
<djgpp@delorie.com> wrote:
>> src\libc\dpmi\api\d0306.S, line 2-line 4.
>>
>> code before fix:
>> #define USE_EBX
>> #define USE_EDI
>> #include "dpmidefs.h"
>>
>> possible fix:
>> #define USE_EBX
>> #define USE_EDI
>> #define USE_ESI
>> #include "dpmidefs.h"
>
> Yes, looks very reasonable, given that the DPMI call explicitly changes
> (e)si.

OK then, is the following patch OK to apply?

___dpmi_get_raw_mode_switch_addr: push/pop esi.

Reference issue:
https://www.delorie.com/djgpp/mail-archives/browse.cgi?p=djgpp/2022/08/02/03:07:56

Index: src/libc/dpmi/api/d0306.S
===================================================================
RCS file: /cvs/djgpp/djgpp/src/libc/dpmi/api/d0306.S,v
retrieving revision 1.1
diff -u -p -r1.1 d0306.S
--- src/libc/dpmi/api/d0306.S 12 Mar 1995 04:52:56 -0000 1.1
+++ src/libc/dpmi/api/d0306.S 7 Aug 2022 04:08:36 -0000
@@ -1,6 +1,7 @@
/* Copyright (C) 1995 DJ Delorie, see COPYING.DJ for details */
#define USE_EBX
#define USE_EDI
+#define USE_ESI
#include "dpmidefs.h"

.text

Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI register and doesn't save it

<83r11sy6ar.fsf@gnu.org>

  copy mid

https://www.novabbs.com/devel/article-flat.php?id=210&group=comp.os.msdos.djgpp#210

  copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!feed1.usenet.blueworldhosting.com!peer01.iad!feed-me.highwinds-media.com!news.highwinds-media.com!feeder.usenetexpress.com!tr2.iad1.usenetexpress.com!69.80.99.14.MISMATCH!border-1.nntp.ord.giganews.com!nntp.giganews.com!Xl.tags.giganews.com!local-2.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Sun, 07 Aug 2022 05:27:45 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WhzPA+XJgWefO0Dgvh3q6wrF+EMQXIGp2J3F462X1bk=; b=MboZYpLaqzaJ lRfe95j5ZYKb8Ie50QVe5A2VvdgodL2ClZqJ4djtQ7WXNnwQuYXtd4QftlNhouizoEdo5QoG+vOmd S9WrT/O50HfgXPcpacy2a/CcafreOrwJZAhGePZRndegvBtb5jcd4oF8tfVNezhcHgCE3iosmTTm9 FMcA9JpBXDfeluPzYA6qG+4RBdxuiykeBVCePRxvGE08UeUBMNzOKwOx8EaiTkQsrLb/2ZiUrBq3Q 1uRctdJlIPU2HPvmytay5qxslDpGwtPbc/er5S5xXAE+tJjIArT+qUlF9RRMDMg3Vjq8VUdiW3yxf IjhGLA/qd9c4GrfMm3wkhw==;
Date: Sun, 07 Aug 2022 08:24:44 +0300
Message-Id: <83r11sy6ar.fsf@gnu.org>
From: djg...@delorie.com (Eli Zaretskii (eliz@gnu.org) [via djgpp@delorie.com])
To: djgpp@delorie.com
In-Reply-To: <CAA2C=vBOy1Yj26JqRHMNjHqv9DE19wuTDZOA0Rq7s0B1xeoq0w@mail.gmail.com> (djgpp@delorie.com)
Subject: Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI register and doesn't save it
References: <3c11b033.75.182562fe32f.Coremail.lostxwind@163.com> <414f3e66.a1.182565154ec.Coremail.lostxwind@163.com> <CAA2C=vCKayVtwbC7xaPtcfZ2a6PDPLAa8K2diCRN52=yi9R_Og@mail.gmail.com> <83b98192-9ce6-495d-8eaf-9c4e6906cb5dn@googlegroups.com> <CAA2C=vBOy1Yj26JqRHMNjHqv9DE19wuTDZOA0Rq7s0B1xeoq0w@mail.gmail.com>
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 24
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-2uyTJc/zPkW3akgFI1WQa35j1MfYogunUSyxsAD8CGlv7uFd4bFz7tvg9jBYolKNw58sCo/MOYf0dI3!93sJ3qL+ixRGtJqfuUxSnQAUG9goXcvS9xFdepuZxkTa
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
X-Received-Bytes: 3077
 by: Eli Zaretskii (eliz@ - Sun, 7 Aug 2022 05:24 UTC

> From: "Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]" <djgpp@delorie.com>
> Date: Sun, 7 Aug 2022 07:14:22 +0300
>
> On 8/6/22, Stefan Ring (stefanrin@gmail.com) [via djgpp@delorie.com]
> <djgpp@delorie.com> wrote:
> >> src\libc\dpmi\api\d0306.S, line 2-line 4.
> >>
> >> code before fix:
> >> #define USE_EBX
> >> #define USE_EDI
> >> #include "dpmidefs.h"
> >>
> >> possible fix:
> >> #define USE_EBX
> >> #define USE_EDI
> >> #define USE_ESI
> >> #include "dpmidefs.h"
> >
> > Yes, looks very reasonable, given that the DPMI call explicitly changes
> > (e)si.
>
> OK then, is the following patch OK to apply?

Yes, thanks.

Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI register and doesn't save it

<CAA2C=vBNjX85L0PNabMu7gB76zC6gF+AYx=At0T0GG0JGC6ZTw@mail.gmail.com>

  copy mid

https://www.novabbs.com/devel/article-flat.php?id=211&group=comp.os.msdos.djgpp#211

  copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!weretis.net!feeder6.news.weretis.net!news.misty.com!border-2.nntp.ord.giganews.com!nntp.giganews.com!Xl.tags.giganews.com!local-1.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Sun, 07 Aug 2022 05:41:16 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:from:to:cc;
bh=HBBwCYXOEv8g4P3im5c1qXFrqmYQqMZohdT7+ZVlGfs=;
b=W1kxTWKZpnHLunGl6BMBDqo3N+0vvwwHS2z0mEUFrSHvDByBs3LitpBsvvNcmHjNX4
iXkR3+FXTshuZD0R0nZ1z5b3WMsfwX4yZramH3SrUceHpi0UF7zQlG06xs8eKurI0CqB
BayXdjQR0k3tBH4hI3Ki893d3oOiRgJS5XTPsV9AZTfVW552Gqz8XNQVeoL27exdJvkU
Y0cNl7wKc7boNnB6I2CBCsuutAjEpQ4VOfhlejFyiww0P9h0IdtW37ISLPLcF2ttFxUV
ky960cFrzY7p1XYn9W/xJHFTCwHtqBgRswCBEe+87a1qHNh4lowE2Y9n1Cr6NaLtHxXz
5kvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:x-gm-message-state:from:to:cc;
bh=HBBwCYXOEv8g4P3im5c1qXFrqmYQqMZohdT7+ZVlGfs=;
b=ucoDo4PXlRW9mFXDtcrFh+HANfq7/pL2I7BxTIkQ3MeVwxWSwk8+yd57fvpb2Czoto
CiG+/zqLxjjGn+fkFo9NKDjWmOLMQIVInL+fI29pYktCwF2YmuITiEkCIPgm7f4ZAQVq
zXctPErgF6et52vsC0HSQmtOTpBA21FgZq8OV3VFlLi4Cp+VKD8MA7koMqzrb/79ferr
xJTp/E5TRGzO0X77jrFTmzttAVPASLS6VvW2kKnTsWTBm3bnHCvN4WFX4LXj+U3DM1/V
Juyo6XckQXSMbljAYv5GgWW3rDXKj5m2H8dXMTl8QpOWOJ0KTtcTSDJ/GilGCs8Ut1TK
OGnQ==
X-Gm-Message-State: ACgBeo0GJsYU6F6D3XgQiTnetxmEWJCvF3/lk44M3MFzFrkoi9L4O4sM
jVecShOx9jKChRZAgRIQedgyrLQv1QNbwd6i77o5p0Uj9hM=
X-Google-Smtp-Source: AA6agR7IgARaxvzpGdXSWFiW5IGKrekOhCTiDyUb+XAssYzvfVA+fHyZwpBxUPKD76GQqFFgawdHe4NmDoF98qvTK50=
X-Received: by 2002:adf:ec92:0:b0:21f:f65:2e57 with SMTP id
z18-20020adfec92000000b0021f0f652e57mr7945943wrn.95.1659850722960; Sat, 06
Aug 2022 22:38:42 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <83r11sy6ar.fsf@gnu.org>
References: <3c11b033.75.182562fe32f.Coremail.lostxwind@163.com>
<414f3e66.a1.182565154ec.Coremail.lostxwind@163.com> <CAA2C=vCKayVtwbC7xaPtcfZ2a6PDPLAa8K2diCRN52=yi9R_Og@mail.gmail.com>
<83b98192-9ce6-495d-8eaf-9c4e6906cb5dn@googlegroups.com> <CAA2C=vBOy1Yj26JqRHMNjHqv9DE19wuTDZOA0Rq7s0B1xeoq0w@mail.gmail.com>
<83r11sy6ar.fsf@gnu.org>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Sun, 7 Aug 2022 08:38:42 +0300
Message-ID: <CAA2C=vBNjX85L0PNabMu7gB76zC6gF+AYx=At0T0GG0JGC6ZTw@mail.gmail.com>
Subject: Re: BUGREPORT: ___dpmi_get_raw_mode_switch_addr() modifies SI
register and doesn't save it
To: djgpp@delorie.com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 30
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-5gOKdqzdo1JXkW5Sc8uhehgplShBQvwLkQNiQPz4O5gqI7DvsIsgPUolBmVGPbPB2/LYO7h/qS8NGhP!jEJE9YQg+vfYIP8xGJkmQ66lrHnodiN+jgyAOKM47Ox16FeEx3GgG7muT6TKj5Q+/2eOLtJZyahK!EEAwELdCFS2EC33Rkc2k6QKxXC0=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
 by: Ozkan Sezer (sezeroz - Sun, 7 Aug 2022 05:38 UTC

On 8/7/22, Eli Zaretskii (eliz@gnu.org) [via djgpp@delorie.com]
<djgpp@delorie.com> wrote:
>> From: "Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]"
>> <djgpp@delorie.com>
>> Date: Sun, 7 Aug 2022 07:14:22 +0300
>>
>> On 8/6/22, Stefan Ring (stefanrin@gmail.com) [via djgpp@delorie.com]
>> <djgpp@delorie.com> wrote:
>> >> src\libc\dpmi\api\d0306.S, line 2-line 4.
>> >>
>> >> code before fix:
>> >> #define USE_EBX
>> >> #define USE_EDI
>> >> #include "dpmidefs.h"
>> >>
>> >> possible fix:
>> >> #define USE_EBX
>> >> #define USE_EDI
>> >> #define USE_ESI
>> >> #include "dpmidefs.h"
>> >
>> > Yes, looks very reasonable, given that the DPMI call explicitly changes
>> > (e)si.
>>
>> OK then, is the following patch OK to apply?
>
> Yes, thanks.
>

Applied: https://www.delorie.com/bin/cvsweb.cgi/djgpp/src/libc/dpmi/api/d0306.S

1
server_pubkey.txt

rocksolid light 0.9.8
clearnet tor