Rocksolid Light

Welcome to novaBBS (click a section below)

mail  files  register  newsreader  groups  login

Message-ID:  

Memories of you remind me of you. -- Karl Lehenbauer


devel / comp.os.msdos.djgpp / Re: [PATCH] dxe3gen: add support for using an exports file.

SubjectAuthor
* [PATCH] dxe3gen: add support for using an exports file.Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]
`* Re: [PATCH] dxe3gen: add support for using an exports file.Eli Zaretskii (eliz@gnu.org) [via djgpp@delorie.com]
 `* Re: [PATCH] dxe3gen: add support for using an exports file.Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]
  `* Re: [PATCH] dxe3gen: add support for using an exports file.Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]
   `* Re: [PATCH] dxe3gen: add support for using an exports file.Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]
    `* Re: [PATCH] dxe3gen: add support for using an exports file.Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]
     `* Re: [PATCH] dxe3gen: add support for using an exports file.Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]
      `* Re: [PATCH] dxe3gen: add support for using an exports file.Eli Zaretskii (eliz@gnu.org) [via djgpp@delorie.com]
       `- Re: [PATCH] dxe3gen: add support for using an exports file.Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]

1
[PATCH] dxe3gen: add support for using an exports file.

<CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=320&group=comp.os.msdos.djgpp#320

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!weretis.net!feeder8.news.weretis.net!border-2.nntp.ord.giganews.com!nntp.giganews.com!Xl.tags.giganews.com!local-1.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Mon, 30 Jan 2023 17:31:09 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=+JT9sW0foPo1jJ14CAGo7q8NLa/Ei5AZAn58EAnXYU8=;
b=IRJGwPTQgc08E2r1jlDVrrr0vd3nSAdBa7DyVuqQuW7BuHzpickt8BXlBb0N3ZAAGq
6nPJ/AwzhST5Yfxa+w+I97K6LLQRsyQYCt+MD9+er3SBbvaC5ARv50V5aRUfdWXyxvdP
DQ83PLJon/4UxvwTb0jr9STfy3QMtCko1xik9a+rtMqQmIiGbZbgR019TZZKWSkQ/NOu
p9Af/nBKZ6qe5xvU+radoAYsB9mKckYVAUP+pi3K0gwOnZLJOeycaHa6g3aHxR5ShHaU
3RDef41Ai4Lj0tcy0bLSDoafEIf+7hO+354gr0OLqkEZsjxxXCDXRc0uTj/pX2HsmPAn
X0KQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=+JT9sW0foPo1jJ14CAGo7q8NLa/Ei5AZAn58EAnXYU8=;
b=OlTNg4zdEf2etmA5TTGECQqGspOvA2Tl1kMYqVjn1J3VD8kqWOj48cmZWjHut3Yu7h
F8RkfWcrU3h+ivvS6yObfrYRLcBEkxEt/L9IP2vguE6PFkWjEYY2xGZCePDMVu4gbmga
waUrULxruq0cu30DfTweC5iSGLHPTULz/zBZlhN1wXlZCZqErNhhySZ6xp2LUkO22ZVg
i3/K3gNQm8yWPTUy38CvMlMPa4VJ3s5c5K8As0MRe6GMkFk96QGC2eH7ePNKVEuFzKDS
g9eZJjXGBbLBXQgf+zgKGbwojPfTLefXWOeKmodzUJxLYx0gDqnRBXa+gN5dEnd86hGi
0HTQ==
X-Gm-Message-State: AFqh2kpf+ff+uJJov74YhMurrDTVcJzdOx4iHN4cAmtx0Vg2H3gI9RpK
pQ9rOt4d9/xrvg6BUFpmCz+uf6Ef0BFHHNySzyltaOXj
X-Google-Smtp-Source: AMrXdXtXoKI2N477xPZl47gup6+GgO4P+VpaQEm6kZ1F9WE7BqvMFQB/mo8mduU9YQqQ36EtyhCo8NtAMKdRj+AWl54=
X-Received: by 2002:a05:600c:4ca7:b0:3cf:7b68:631 with SMTP id
g39-20020a05600c4ca700b003cf7b680631mr2414717wmp.55.1675099672056; Mon, 30
Jan 2023 09:27:52 -0800 (PST)
MIME-Version: 1.0
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Mon, 30 Jan 2023 20:27:51 +0300
Message-ID: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com>
Subject: [PATCH] dxe3gen: add support for using an exports file.
To: djgpp@delorie.com
Content-Type: multipart/mixed; boundary="000000000000eaaa5a05f37e8882"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 314
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-1BoRAsuKR3JEuC4GqgxItC+ES63MOByZiwpKQ3vx4YLD8ZrqO8FxjZaL89reZuMnSZJd/DVl8rg0OtA!pbcgIVfN7x/b7NoURbV+WHIL6hfy3YlSa0/2pEIm/Eq290Vyw7axIxYo8Hb/1U1p0OmBzWxlrLVf!vvZz9QupQvKav9uDpmx7LieBwZg=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
 by: Ozkan Sezer (sezeroz - Mon, 30 Jan 2023 17:27 UTC
Attachments: "exports.patch" (text/x-patch)

The patch inlined below (also attached for convenience) adds support for
using an exports file to dxe3gen.

The existing mechanism for exported symbols is through symbol prefixes,
i.e. the -E and -X switches, but can be really hard to use especially if
there are many symbols which don't necessarily share a common prefix, or
if some of the symbols to exclude share the common prefix with symbols
to export.

The exports file is a plain text file with one symbol name at each line,
like an exports file that can be used in macOS projects. No trailing or
leading space/tab should be used in the file. A line starting with a '#'
character is a comment line and will be ignored.

The -E and -X switches are still supported, but those two are mutually
exclusive.

Eli, Juan, DJ: Please review. OK to apply?

Index: dxe3gen.c
===================================================================
RCS file: /cvs/djgpp/djgpp/src/dxe/dxe3gen.c,v
retrieving revision 1.27
diff -u -p -r1.27 dxe3gen.c
--- djgpp/src/dxe/dxe3gen.c 28 Jan 2023 14:10:03 -0000 1.27
+++ djgpp/src/dxe/dxe3gen.c 30 Jan 2023 17:10:28 -0000
@@ -277,6 +277,9 @@ static struct
char *implib; /* name of import library */
char *dxefile; /* the name of dxe file on command line */
char *description; /* a description of the module */
+ unsigned int num_names; /* number of exported symbol names */
+ unsigned int max_names; /* maximal number of exported symbol names */
+ char **export_names; /* exported symbol names */
unsigned int num_prefix; /* number of exported prefixes */
unsigned int max_prefix; /* maximal number of exported prefixes */
char **export_prefix; /* exported symbol prefixes */
@@ -307,6 +310,9 @@ static struct
NULL,
0,
0,
+ NULL,
+ 0,
+ 0,
NULL
};

@@ -319,6 +325,8 @@ static char *dxe_ar; /* default: "ar" */
static char *dxe_ld; /* default: "ld" */
/* linker script */
static char *dxe_sc; /* default: "dxe.ld" */
+/* exports file */
+static char *expfile;

/* Desc: replaces backslash with slash in a path
@@ -422,6 +430,7 @@ static void display_help(void)
printf("-X prefix\tExclude symbols that start with <prefix> (cumulative)\n");
printf("-U\t\tAllow unresolved symbols in DXE file\n");
printf("-V\t\tVerbose output (minimal output by default)\n");
+ printf("--exports file\tExport symbols from this file (mutually
exclusive with -E/-X)\n");
printf("--show-dep\tShow dependencies for specified module\n");
printf("--show-exp\tShow symbols exported by the DXE module\n");
printf("--show-unres\tShow unresolved symbols in the DXE module\n");
@@ -465,6 +474,57 @@ static void process_env(void)
}

+/* Desc: process the exports file pointed to by --exports option.
+ *
+ * In : -
+ * Out : -
+ *
+ * Note: -
+ */
+static void process_exp_file(const char *name)
+{
+ FILE *f = fopen(name, "rb");
+ char *ptr;
+ long len;
+ + if (!f)
+ {
+ fprintf(stderr, "Error: Couldn't open exports file %s.\n", name);
+ exit(1);
+ }
+ + fseek(f, 0, SEEK_END);
+ len = ftell(f);
+ fseek(f, 0, SEEK_SET);
+ expfile = malloc(len + 1);
+ fread(expfile, 1, len, f);
+ fclose(f);
+ expfile[len] = '\0';
+ + for (ptr = expfile; ; )
+ {
+ while (*ptr == '\r' || *ptr == '\n')
+ *ptr++ = '\0';
+ + if (!*ptr) break;
+ + if (*ptr == '#') /* comment */
+ goto loc1;
+ + if (opt.num_names >= opt.max_names)
+ {
+ opt.max_names += 16;
+ opt.export_names = (char **)realloc(opt.export_names,
opt.max_names * sizeof(char *));
+ }
+ opt.export_names[opt.num_names++] = ptr++;
+ + loc1:
+ while (*ptr != '\r' && *ptr != '\n')
+ ++ptr;
+ }
+}
+ +
/* Desc: process command line args
*
* In : no of arguments, argument list, ptr to store linker args
@@ -475,6 +535,7 @@ static void process_env(void)
static void process_args(int argc, char *argv[], const char *new_argv[])
{
int i, new_argc = NUMBER_OF_LINKER_ARGS;
+ int use_exports = 0;

if (!libdir)
{
@@ -482,6 +543,17 @@ static void process_args(int argc, char
exit(1);
}

+ for (i = 1; i < argc; ++i)
+ {
+ if (!strcmp(argv[i], "--exports"))
+ ++use_exports;
+ }
+ if (use_exports > 1)
+ {
+ fprintf(stderr, "Error: multiple --exports arguments not allowed.\n");
+ exit(1);
+ }
+ new_argv[0] = dxe_ld;
new_argv[1] = "-X";
new_argv[2] = "-S";
@@ -513,6 +585,11 @@ static void process_args(int argc, char
printf("Usage: %s output.dxe symbol input.o [input2.o ... -lgcc
-lc]\n", progname);
exit(-1);
}
+ if (use_exports)
+ {
+ fprintf(stderr, "Error: --exports not allowed in legacy mode.\n");
+ exit(1);
+ }

opt.max_prefix = 16;
opt.export_prefix = (char **)malloc(opt.max_prefix * sizeof(char *));
@@ -552,8 +629,13 @@ static void process_args(int argc, char
opt.implib = argv[++i];
opt.autoresolve = TRUE;
}
+ else if (!strcmp(argv[i], "--exports"))
+ {
+ process_exp_file(argv[++i]);
+ }
else if (!strcmp(argv[i], "-E"))
{
+ if (use_exports) goto bad_exports;
if (opt.num_prefix >= opt.max_prefix)
{
opt.max_prefix += 16;
@@ -563,6 +645,11 @@ static void process_args(int argc, char
}
else if (!strcmp(argv[i], "-X"))
{
+ if (use_exports)
+ { bad_exports:
+ fprintf(stderr, "Error: --exports and -E / -X options are
mutually exclusive\n");
+ exit(1);
+ }
if (opt.num_excl >= opt.max_excl)
{
opt.max_excl += 16;
@@ -1185,6 +1272,21 @@ static int write_dxe(FILE *inf, FILE *ou
continue;
}

+ if (opt.num_names)
+ {
+ BOOL ok = FALSE;
+ for (j = 0; j < opt.num_names; j++)
+ {
+ if (strcmp(opt.export_names[j], name) == 0)
+ {
+ ok = TRUE;
+ break;
+ }
+ }
+ if (!ok)
+ continue;
+ }
+ /* exported symbol */
dh.n_exp_syms++;

Attachments: "exports.patch" (text/x-patch)
Re: [PATCH] dxe3gen: add support for using an exports file.

<835ycn529o.fsf@gnu.org>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=321&group=comp.os.msdos.djgpp#321

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!feed1.usenet.blueworldhosting.com!peer03.iad!feed-me.highwinds-media.com!news.highwinds-media.com!feeder.usenetexpress.com!tr3.iad1.usenetexpress.com!69.80.99.23.MISMATCH!Xl.tags.giganews.com!local-2.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Mon, 30 Jan 2023 18:06:06 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UGZOG7wh3OzL0Ar/qzbPDuRIEIJwzb21p86EQnksSzk=; b=rAFWEp7M1h7M F9RDrT1TJv8THAsYUKeMV6AT+/T70vrl72WlyQFEcicN7RHhLshOc5Qxtwa6Z9cd6juxd0vcCGrmm HjsF/QVpjvCO7qDDBu9BGefApSO6WjOEtr84GQt7cA0mM8R6huxK462ii7AQe4eAIA+AxBWIiZzXc mjKe+UacLBfIosKIz3m0uRjoNhhj0cKklo1qoALQgPBNOYPiU5ZPeuWN0hEHTY4rXCQE6Xhh5HFja WmhZJTpKTnlfmlTeNbEv6d8MMbAn2ypwSFEfsKsNZ3SKFjatCJeV2rL9vVZBjhvU3+/SJpRu0CQEc AcPPR2DzYJodhLDwvLIrpw==;
Date: Mon, 30 Jan 2023 20:02:43 +0200
Message-Id: <835ycn529o.fsf@gnu.org>
From: djg...@delorie.com (Eli Zaretskii (eliz@gnu.org) [via djgpp@delorie.com])
To: djgpp@delorie.com
In-Reply-To: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com> (djgpp@delorie.com)
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com>
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 23
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-2ziAHriUhAjN3tfB1CNbZuYhZwgPE/ifWgg8sU7VM8NbT3fb6bGzvZHHDMp5ckvaULoYbpZrXKRjp24!6U9k9JOPlpY1kbXDBx6hrpXQRMh31RnF4ZbyPutTJyAq
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
X-Received-Bytes: 3162
 by: Eli Zaretskii (eliz@ - Mon, 30 Jan 2023 18:02 UTC

> From: "Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]" <djgpp@delorie.com>
> Date: Mon, 30 Jan 2023 20:27:51 +0300
>
> The patch inlined below (also attached for convenience) adds support for
> using an exports file to dxe3gen.
>
> The existing mechanism for exported symbols is through symbol prefixes,
> i.e. the -E and -X switches, but can be really hard to use especially if
> there are many symbols which don't necessarily share a common prefix, or
> if some of the symbols to exclude share the common prefix with symbols
> to export.
>
> The exports file is a plain text file with one symbol name at each line,
> like an exports file that can be used in macOS projects. No trailing or
> leading space/tab should be used in the file. A line starting with a '#'
> character is a comment line and will be ignored.
>
> The -E and -X switches are still supported, but those two are mutually
> exclusive.
>
> Eli, Juan, DJ: Please review. OK to apply?

LGTM, but why did you use binary mode for reading the exports file?

Re: [PATCH] dxe3gen: add support for using an exports file.

<CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=322&group=comp.os.msdos.djgpp#322

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!feed1.usenet.blueworldhosting.com!peer01.iad!feed-me.highwinds-media.com!news.highwinds-media.com!feeder.usenetexpress.com!tr3.iad1.usenetexpress.com!69.80.99.26.MISMATCH!Xl.tags.giganews.com!local-2.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Mon, 30 Jan 2023 18:23:41 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=fGLFv2WtfllE/+vQ7VmqhNL8aIj56wPXS8FwG/zBiwU=; b=M3dUiHoPgWYUDPztMxseEU2H9dMibOXaqYp3E5yLgDofwadE3uS8yhXsJ4q4cq34Uu 35iFe6Ll5H9btcL2NjpsAdXNJWGS134p96g4OMv4V5hAWqNi+8Kdol6G01FMiNt4yrXu mKGIx9wAC2UKzdFoo0OH03qxfxRBM3Uj19jP0ASGZ0WaxnxAA/nH11waQsi+EFBfuGMG g8RFATXnjdpmLf1uugc/KF0F6skKVqUcihwE+Q9SUcQNOLNrPKDWMTpzXbUSmLUcJMd2 uA8WtBSRCtWscJ1ak+usdICxEVeAjh8aKH9WEzRWHxiAvx6Pb8f7nzhkaOScu2SyyQcn SyIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fGLFv2WtfllE/+vQ7VmqhNL8aIj56wPXS8FwG/zBiwU=; b=bgkeoxZgmHnlt9NRkvU+GWyZvCwD9Ya6xsYZH1KQ+MXFWJkMsKHAgsoW3CfQ5h84ZG TOIl62qOtC2wsSZB5Hio1RaQVsie/R2AW1f0SQ4Z6TSBY1VYAo1c483cNC2pEMZHQ709 EOWRPIntM6J/inB8HcId41bwurJJs6Yghgk7Qdj92R/uCcBKPRA58P9/9DlC4tV0grpP qDCxdHELeFvf4xVvHD22VUhEj3y4bdn3qMXmDne3GVcrNBhx1nKa8eVj+RnzOcnseWKR mOc9aku8db0Z7w3xYsB3OM1it8QZw3j+Vj27FFyz2yQ7unH/ngMXtp3gBxDEHCNnYFNX YL8w==
X-Gm-Message-State: AFqh2kpXxBBYroDDo3men2vJGs7fwEI4t8TyUIOh5P+Ana4zlCmlFNRh lOHS8xZK8J8shIJsOYL14fD2JulZkozGbZp4JC1CvTTT
X-Google-Smtp-Source: AMrXdXtVjzEuXVbErKPDj14we5hQllqrx2FjQOejIbZRXa70UPw2suCpicyxoLVZF7ufc2jEQTN+lF3vSq311XqJAdk=
X-Received: by 2002:a05:600c:5403:b0:3db:2fd:46b with SMTP id he3-20020a05600c540300b003db02fd046bmr2323360wmb.180.1675102825404; Mon, 30 Jan 2023 10:20:25 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <835ycn529o.fsf@gnu.org>
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com> <835ycn529o.fsf@gnu.org>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Mon, 30 Jan 2023 21:20:24 +0300
Message-ID: <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com>
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
To: djgpp@delorie.com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 7
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-tN2gWm/4oyTNGiSpepsIxdOBcQDPgtmiKyy7P0EaP1+sqwBAtxDUkvV6REblvO7DTovQGg3TOUo9erb!hqit9wq7a4QrYxQF2GenxThFAI2KYP5WRcp0XYSIvoUQsE7M5MiVX9skvEVwSNbqt0hCPV/cmuDG!0toFkcUg2FOHieTsmP7GWlghTWE=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
X-Received-Bytes: 3505
 by: Ozkan Sezer (sezeroz - Mon, 30 Jan 2023 18:20 UTC

> LGTM,

OK, can apply tomorrow unless I get further reviews/objections.

> but why did you use binary mode for reading the exports file?

Easier forme that way -- uniform parsing across platforms.

Re: [PATCH] dxe3gen: add support for using an exports file.

<CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ@mail.gmail.com>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=325&group=comp.os.msdos.djgpp#325

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!weretis.net!feeder8.news.weretis.net!border-2.nntp.ord.giganews.com!nntp.giganews.com!XbbXl.tags.giganews.com!local-1.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Tue, 31 Jan 2023 06:29:18 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:from:to:cc:subject:date:message-id:reply-to;
bh=pklKglPNk3TzvSQaN3vremLJ8d4nIiLvErv7JbQIK5o=;
b=ojTb6KpRbFmUjUMmCSYSsB8tJOCDyrEc/bm5JoOFVXWgEavnE37Jt0cdiN7rRDhtDl
geIkZ1Ah2th92PkSkimrzzrrEr+J9fTq1auzWIhXuypuxOcgp9vm2YAvNc1ZxW4RYb3J
/e/lw6YpnT3lgqu/EsXQsuhMrBjlEklnomLo3APo9j2XkUFojQLVu+IbFKiDLtLrhGXj
RAqUu9M3//gxXmeuY1T3NcltjSYtJjoXzxdTpokWvfjT4P0R4CbeHRCKb8brS2/4Ir7F
p9OZdPOPGXdZ6/YrNc5PM7aBubPVbCgP/CEOHl0hfAox+bcNegoCqWY3CqPJa0xKCq73
TN3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=pklKglPNk3TzvSQaN3vremLJ8d4nIiLvErv7JbQIK5o=;
b=o/V4JikqY2j6Q+LWXvrM9+AwbBYus1I1xlpNFtLg0ysSJ3HSNaspl5s0l5AK6l3P8M
lstvedQmmb6poO+vqvHGOlniRlyA94iCadcfuwdjlTs4g00vdUMclHVHmrONcGjnqqFq
j67c8hHOq+iGFSnSWc659+D+GhKmcQZM83CKM98UeBEyxl338I6MXprtm8akbi6ulB7m
na7iyfrW4a+ebHk113EF7cqXRWgn4vnJxrFv5lQKIryi8aM4CDGI13UICC9fRI5aJgH6
vF74WTT5mWT/nXcwe6Jq3WiL8aAslz01PHQ9wBSIkRBrKZwScnCvTb3SlKGkgjtguabK
4y6w==
X-Gm-Message-State: AFqh2kraHgOvtn2J7AoLx0lUAlqLer1ifl8LcVAmi0F65E7Oe89FpZgG
WQGRlClHVTetzu84o98MccZ2KoTMT3bOt/K5qw63Dfsq
X-Google-Smtp-Source: AMrXdXun93EIQn1OLuyMYMkYVCAoefe6zy3QWrGra88YtfvXN6gZDe3PC2uH/EpVshrvAioTVinEWd2bqnB62fcITXA=
X-Received: by 2002:a05:600c:1d25:b0:3da:fa8a:8511 with SMTP id
l37-20020a05600c1d2500b003dafa8a8511mr3069271wms.185.1675146358003; Mon, 30
Jan 2023 22:25:58 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com>
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com>
<835ycn529o.fsf@gnu.org> <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Tue, 31 Jan 2023 09:25:56 +0300
Message-ID: <CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ@mail.gmail.com>
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
To: djgpp@delorie.com
Content-Type: multipart/mixed; boundary="0000000000009dc48605f38967c3"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 170
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-T1NpUZzYGWQ0jSXXOGne4PGJpYAk0w4xSJK5F+BWT+T/lQ9+D1T/rXpjNBf8EKU9r2yMSCRumdbGMhc!eetltNB37aIAExqIv/oarv+77YLAM9YBJgLvxSZ8d+VdWzzNWxkAnAhXlfgcz1YWNLYj75+MMSwP!3jls3WjeNtALJZwKbBzn4D86fMI=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
 by: Ozkan Sezer (sezeroz - Tue, 31 Jan 2023 06:25 UTC
Attachments: "exports2.patch" (text/x-patch)

On 1/30/23, Ozkan Sezer <sezeroz@gmail.com> wrote:
>> LGTM,
>
> OK, can apply tomorrow unless I get further reviews/objections.
>
>> but why did you use binary mode for reading the exports file?
>
> Easier forme that way -- uniform parsing across platforms.

Version 2 of patch attached. Changes:

- Fixes segfault if the exports file has no newline at end
- Reports missing exports in verbose mode.

For convenience, an interdiff to first version is inlined below
(cosmetic changes excluded.)

--- dxe3gen.c~
+++ dxe3gen.c
@@ -519,7 +520,7 @@
opt.export_names[opt.num_names++] = ptr++;

loc1:
- while (*ptr != '\r' && *ptr != '\n')
+ while (*ptr && *ptr != '\r' && *ptr != '\n')
++ptr;
}
}
@@ -1277,9 +1278,12 @@
BOOL ok = FALSE;
for (j = 0; j < opt.num_names; j++)
{
+ if (!opt.export_names[j])
+ continue;
if (strcmp(opt.export_names[j], name) == 0)
{
ok = TRUE;
+ opt.export_names[j] = NULL;
break;
}
}
@@ -1310,6 +1314,15 @@
}
DEBUG_PRINT_SYMBOL_TABLE_EPILOG();

+ if (opt.verbose && opt.num_names && opt.num_names != dh.n_exp_syms)
+ {
+ for (j = 0; j < opt.num_names; j++)
+ {
+ if (opt.export_names[j])
+ printf("missing export: `%s'\n", opt.export_names[j]);
+ }
+ }
+ if (errcount)
{
fclose(outf);

Attachments: "exports2.patch" (text/x-patch)
Re: [PATCH] dxe3gen: add support for using an exports file.

<CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w@mail.gmail.com>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=326&group=comp.os.msdos.djgpp#326

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!weretis.net!feeder8.news.weretis.net!border-2.nntp.ord.giganews.com!nntp.giganews.com!XbbXl.tags.giganews.com!local-1.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Tue, 31 Jan 2023 08:46:22 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:from:to:cc:subject:date:message-id:reply-to;
bh=Cy+2UShq3YpWU5ZSmom3hlJOyb/JruAjXXptdZMXcT0=;
b=UdpbowyHiuIcLr4muK8jQRU7HOao4XLL60rTr6EoIBpHhI7IJB93Rgavc+WTOogfKe
CSzq8Vw+oAWP6LGVzSyrEEgCRcPyQ4nCxA8UMsxQgj6poZrWPrYI6RkXUX6AUSxxvcrp
aqKu0HAzafd7zyE3fv7j3hGSwEAHW+HlO/Cwd1rYcZ93cx3o/hXcD5roJITXgAaxHb4T
ijU+DOy34gVr7nuv1ZZudDYc8FUNY4I6ianXwL8hbfndzFynn9PPptXTN1gGlJfXHOJj
6UO09BkqGk7cSlKm5yt9sJA2ZG9YFtszMt1JlCD2Lw6/Ps6+2t0XRXM1p8VZ8iKP0dY7
vDpA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=Cy+2UShq3YpWU5ZSmom3hlJOyb/JruAjXXptdZMXcT0=;
b=bNatG7rl7hUHkmQZnh9kUQHg3r4uw7VPvAGCZoJLE9HoTh+odkbFQgNIxvSWq22rIx
FRKB3Y3SL8sag84TXEJ5Su24FLFLzMT+LuaNZcHtw3e+hG4KqL6IaN/IQGH+5SMQVZCu
bqDFt8NS0BTrW+j9CMuOfhKj0BgD1DtN/Xy11W04GsczGmuULOC10wge+e1Ph47SwzNL
4DXAQCFdI/iGYq75AvQCYrgsjB4m7SVGL+Mw1rctqPFVOSwXahXwDUWGl2YZxqsixi8h
XZOnoUC5Qn/+4K1tUTK5mLeu3plOyUvb9GCZ/SKG0hZiDnnaCB2MIXu8T0OBjOashLiS
PvfA==
X-Gm-Message-State: AO0yUKULm7tlAo7vA3P6Ggnc0M/vst//7quVhxHn+5M91ZWv1Roqi5VE
mvnrT/qf6KQBELFh6f+DmvahO0IViaRi5cQs43mYA68z
X-Google-Smtp-Source: AK7set8zd+lfNkzcG3/qaMUw7PpDjT//TUTP3jfSmuWHPILy9UuSzmEoGsb6ivgfAdZt2QPC+6RVDT5KKM3m3Z9m3P8=
X-Received: by 2002:a5d:5b0b:0:b0:2bf:bc64:bb40 with SMTP id
bx11-20020a5d5b0b000000b002bfbc64bb40mr499828wrb.34.1675154582068; Tue, 31
Jan 2023 00:43:02 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ@mail.gmail.com>
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com>
<835ycn529o.fsf@gnu.org> <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com>
<CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ@mail.gmail.com>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Tue, 31 Jan 2023 11:43:00 +0300
Message-ID: <CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w@mail.gmail.com>
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
To: djgpp@delorie.com
Content-Type: multipart/mixed; boundary="000000000000cefd5105f38b5192"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 230
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-dVrKRSwb800YxkmuYNyHI6zUvHwvq3rpmFTJ+Yww2kAVwOjmNIn+WaM/R5t6Monu77IVM9AZLak7Ljd!99c0EziUC8bgB+4ukKGzPrXRVuj3jPEoy+F+yMG6b/PCGM/a1alBD2+2ohOZRb8nliuPTOZacXew!VNfUT9hQGoKZpMrrv2Y4bhL2ba4=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
 by: Ozkan Sezer (sezeroz - Tue, 31 Jan 2023 08:43 UTC
Attachments: "exports3.patch" (text/x-patch)

>>> LGTM,
>>
>> OK, can apply tomorrow unless I get further reviews/objections.
>>
>>> but why did you use binary mode for reading the exports file?
>>
>> Easier forme that way -- uniform parsing across platforms.
>
> Version 2 of patch attached. Changes:
>
> - Fixes segfault if the exports file has no newline at end
> - Reports missing exports in verbose mode.
>
> For convenience, an interdiff to first version is inlined below
> (cosmetic changes excluded.)
>
> --- dxe3gen.c~
> +++ dxe3gen.c
> @@ -519,7 +520,7 @@
> opt.export_names[opt.num_names++] = ptr++;
>
> loc1:
> - while (*ptr != '\r' && *ptr != '\n')
> + while (*ptr && *ptr != '\r' && *ptr != '\n')
> ++ptr;
> }
> }
> @@ -1277,9 +1278,12 @@
> BOOL ok = FALSE;
> for (j = 0; j < opt.num_names; j++)
> {
> + if (!opt.export_names[j])
> + continue;
> if (strcmp(opt.export_names[j], name) == 0)
> {
> ok = TRUE;
> + opt.export_names[j] = NULL;
> break;
> }
> }
> @@ -1310,6 +1314,15 @@
> }
> DEBUG_PRINT_SYMBOL_TABLE_EPILOG();
>
> + if (opt.verbose && opt.num_names && opt.num_names != dh.n_exp_syms)
> + {
> + for (j = 0; j < opt.num_names; j++)
> + {
> + if (opt.export_names[j])
> + printf("missing export: `%s'\n", opt.export_names[j]);
> + }
> + }
> +
> if (errcount)
> {
> fclose(outf);

Version 3 of the patch attached. Changes:

- Leading or trailing whitespace in symbol name line are now tolerated.

For convenience, an interdiff to version-2 is inlined below.

--- dxe3gen.c~
+++ dxe3gen.c
@@ -503,25 +503,28 @@ static void process_exp_file(const char

ptr = expfile;
for (;;)
{
- while (*ptr == '\r' || *ptr == '\n')
+ while (*ptr == '\r' || *ptr == '\n' || *ptr == ' ' || *ptr == '\t')
*ptr++ = '\0';

if (!*ptr) break;

if (*ptr == '#') /* comment */
- goto loc1;
+ {
+ while (*ptr && *ptr != '\r' && *ptr != '\n')
+ ++ptr;
+ continue;
+ }

if (opt.num_names >= opt.max_names)
{
opt.max_names += 16;
opt.export_names = (char **)realloc(opt.export_names,
opt.max_names * sizeof(char *));
}
opt.export_names[opt.num_names++] = ptr++;

- loc1:
- while (*ptr && *ptr != '\r' && *ptr != '\n')
+ while (*ptr && *ptr != '\r' && *ptr != '\n' && *ptr != ' ' && *ptr != '\t')
++ptr;
}
}

If you guys don't catch any gotchas, I plan to apply this 3r version to cvs.

Attachments: "exports3.patch" (text/x-patch)
Re: [PATCH] dxe3gen: add support for using an exports file.

<CAA2C=vAQKDYihM7EeYDKSsq0wSqds69xd47oWG=H=SGrKBGTsg@mail.gmail.com>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=327&group=comp.os.msdos.djgpp#327

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!feed1.usenet.blueworldhosting.com!peer01.iad!feed-me.highwinds-media.com!news.highwinds-media.com!Xl.tags.giganews.com!local-1.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Tue, 31 Jan 2023 17:58:52 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:from:to:cc:subject:date:message-id:reply-to;
bh=TX5IzycpiMPxh++69g2bJTKR2Gxjy4Ez3UNZUk+MBFc=;
b=UZMiIaOLewpOCZHm3XHDBNYIVrjrIi3vQq7lS0ClW/BfcNp8bOJUf1APwCBcZLcRRY
ZKwHaosiOKshTzmLo3OlUAh2VZZ03xmMOmKBGx5LmkWKNXTrhATEisgwcTqnxx3+3cpR
n6IbTMy6zcZCb8dzWWSkg0rdeyP7NJjS5m4PK7ZZjOGsHN+mGm7PWzkSAxjC1qCnABDb
sKqUUkq4Vf08W8dS0ZBgXfRWUS9lNN5cfw7BPuZRvMALj6fBV0JIS4sW8q3tQGN+7IsW
92ftDjbnkLBVTliFTTpHcBsfNx+EY3RTmvFFVeOGPMFpYKnuaalbz/Xi19zLeM+mrQ1x
O3eQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=TX5IzycpiMPxh++69g2bJTKR2Gxjy4Ez3UNZUk+MBFc=;
b=mzcPtpa9Z9y2iqXUgQ6eCqkMsDTfT/DqpbOT3DeZd2XhEHU+i44+Uy5hWgOQy3SmfP
yWIA7Mb6q6yMtvBGdOGRdmQKoLguj9x7LE+xBBbaEr5bPXjsy1CYKc3zgoJK6PmxsyRZ
Ox1U9NZUGAxnHJCkMY0lQ1NZCxZ+IzkX/OMVgfu57hiPfYBpzMmJV2nUNbxgVnkFu3HW
IDxclVmMhvgP6e3NdICWraIYVdowjwXO7eN5wwTQ6NmuEwKVNEbdlGev/G1/pU/Bzl3A
xQCgSso9BJsh7bA/bQIXGIVVeZ0kkUQFocuwTa7RsQQh1T4k6xbh2NYvc4eZqhjhgSf6
kVEA==
X-Gm-Message-State: AO0yUKV8AZnLn1nbH115TVY/x50d9DM+I5lp7JPmEV0kWOsIxEv1ewut
T4/sAOApFDxyB9ZmHWjYNctgHuuT3sBmafy7scvr8m6n
X-Google-Smtp-Source: AK7set84qN/n2whLKtVOGon/o1SWEk+sLL9wPVfnOTSXxM6yMeqsoFX/KPeheOoWHF0tM/eqMensoY7wRn+8NBTcFYo=
X-Received: by 2002:adf:e3d0:0:b0:2bf:ed03:3969 with SMTP id
k16-20020adfe3d0000000b002bfed033969mr196438wrm.95.1675187732310; Tue, 31 Jan
2023 09:55:32 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w@mail.gmail.com>
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com>
<835ycn529o.fsf@gnu.org> <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com>
<CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ@mail.gmail.com> <CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w@mail.gmail.com>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Tue, 31 Jan 2023 20:55:31 +0300
Message-ID: <CAA2C=vAQKDYihM7EeYDKSsq0wSqds69xd47oWG=H=SGrKBGTsg@mail.gmail.com>
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
To: djgpp@delorie.com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 26
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-v4sTICkuRh0eZ6SJ8JdXZ9ceMnZT8kulN8Qc9GaMyTi4Q8B77+K1/VgCzauzDAAM7qhpHWyyyJBoFkr!Oza2lbJmT531IyTk1EUXSsUJ3B8fto+2xPKu0IwgmPdW0hZRezV+AsYNw5uH35Xsg4xj+SCd5ATf!f2bH5Uk0GBIw70f4btBGkPeB1ko=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
X-Received-Bytes: 4588
 by: Ozkan Sezer (sezeroz - Tue, 31 Jan 2023 17:55 UTC

> If you guys don't catch any gotchas, I plan to apply this 3r version to
> cvs.

Question: Should I actually make any missing exports an error ?
Patch inlined below.

diff -up djgpp/src/dxe/dxe3gen.c~ djgpp/src/dxe/dxe3gen.c
--- djgpp/src/dxe/dxe3gen.c~
+++ djgpp/src/dxe/dxe3gen.c
@@ -1317,12 +1317,14 @@ static int write_dxe(FILE *inf, FILE *ou
}
DEBUG_PRINT_SYMBOL_TABLE_EPILOG();

- if (opt.verbose && opt.num_names && opt.num_names != dh.n_exp_syms)
+ if (opt.num_names && opt.num_names != dh.n_exp_syms)
{
+ errcount = opt.num_names - dh.n_exp_syms;
+ fprintf(stderr, "Error: %d symbols to be exported are
missing:\n", errcount);
for (j = 0; j < opt.num_names; j++)
{
if (opt.export_names[j])
- printf("missing export: `%s'\n", opt.export_names[j]);
+ fprintf(stderr, "missing export: `%s'\n", opt.export_names[j]);
}
}

Re: [PATCH] dxe3gen: add support for using an exports file.

<CAA2C=vDu4Tgv8L9QYCVVaSJHEF5ArsH0BW8tPiOgTq4UvNnzcA@mail.gmail.com>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=328&group=comp.os.msdos.djgpp#328

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!weretis.net!feeder6.news.weretis.net!news.misty.com!border-2.nntp.ord.giganews.com!nntp.giganews.com!Xl.tags.giganews.com!local-1.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Tue, 31 Jan 2023 19:13:43 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:from:to:cc:subject:date:message-id:reply-to;
bh=n/c6trgUSq7GSwkyQGUUYuEGo3jKskkOsn2oQXtUyHc=;
b=U9QWzHRr7y0gSbF5KaRYU39gYBDBviI93Ixy/YOfMgcHE0cCkCshwulcuNk0tFYjrm
oDdlMkI/Tdw8u4bCDxB6t2QcuQskxlsGhhWc7iQuNiKY2hd6aW52xfbY6UTFYC9NmA2V
ZrcyAvFT0MLCgKe38zJVxWE35I8laGrtZEdU9WfSsaoOrePbeVk9yTuxJVuXpEGLiJmA
MhoPRPJgQKKES1TaPoxk55qTpyRgQktMl4/xM2v3fVEL3UqRWd5FJqizX6ApONn6A98W
A/e8CXyeGqyG+miTsGUxUzP5eVVK0lgAfvytEqlyem3/8FeqWOQTkw+efdltS71zurPA
vjVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=to:subject:message-id:date:from:references:in-reply-to:mime-version
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=n/c6trgUSq7GSwkyQGUUYuEGo3jKskkOsn2oQXtUyHc=;
b=kTdVE87FYVoCAThCSnsxIm3PEqTBB2LZc0yTG5yzrBfX46OVAWUtVxG0p3Uj6DU7bU
a4Yh+y7N3/sS300M6hLcA0h8pxKZPmRBcTzrchdynHFkHb5NMtH4H5FhuXkFRe38jACx
57o0DMhiYmzLFN15AtF6/FOOjbp/UwDLi+8CY6QCPBnwDbg3YHYGIKOsAM3kq5m8hk4I
BOG6nbCk9jwGt3BhbcTuBPETPf7L0dbysrLGGVtnYlBUatWmx063ALd+r/LQV2LQCRJJ
e5KH3cmKGxKKSpZ49+ZTUq5GSu4TmcdEpRfjaH2fldeQ+tO8yP3GrR3rUyLqdAKPU2VP
liAg==
X-Gm-Message-State: AO0yUKXEh5gvpI+rFJCe/vrfbTMkK618Y/rSw9WZxd28H8r2U0HxSo6j
Voi4tGGQZ3LDmCEkmC6jSeDNl7Kos3jnT0VwlnTYCSYL
X-Google-Smtp-Source: AK7set+JzQWs+pxaky5gtAsBaCOscE+gzPfVlai0SyF5ShkRU46Gk0pn7NTcXxsDd7hhIS5cQ3YWkcMd85a1xHgkJ6k=
X-Received: by 2002:a05:600c:354f:b0:3dc:40b4:2d1f with SMTP id
i15-20020a05600c354f00b003dc40b42d1fmr724976wmq.174.1675192229251; Tue, 31
Jan 2023 11:10:29 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <83leli1r3c.fsf@gnu.org>
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com>
<835ycn529o.fsf@gnu.org> <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com>
<CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ@mail.gmail.com>
<CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w@mail.gmail.com>
<CAA2C=vAQKDYihM7EeYDKSsq0wSqds69xd47oWG=H=SGrKBGTsg@mail.gmail.com> <83leli1r3c.fsf@gnu.org>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Tue, 31 Jan 2023 22:10:28 +0300
Message-ID: <CAA2C=vDu4Tgv8L9QYCVVaSJHEF5ArsH0BW8tPiOgTq4UvNnzcA@mail.gmail.com>
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
To: djgpp@delorie.com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 11
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-Pd0f3PD3qNWfu16s7UI0O51YSWeqobX+VQ5Vk/2nwaZyiVLrQLOg8SJTEHZOfi7dxqdfv8BIGUkvMPq!EtSCn82zivfs1T/hcRiMZvsEB1HFeD8Fmh+QBemXJntEDl1iOyqz3BcPumpt7f8sOxP7BHg6nRfa!DX8QLoe5cRBMTtW8tFeVajJGlw0=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
 by: Ozkan Sezer (sezeroz - Tue, 31 Jan 2023 19:10 UTC

> Question: Should I actually make any missing exports an error ?
> Patch inlined below.

> Unless this is a real problem,

It is not,

> I'd say do this only under the verbose operation, i.e. optionally.

i.e. error out only in verbose mode, which _can_ lead to problems?
I' suggest inventing a new switch like --nomissing, what do you think?

Re: [PATCH] dxe3gen: add support for using an exports file.

<83k0121otm.fsf@gnu.org>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=329&group=comp.os.msdos.djgpp#329

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!feed1.usenet.blueworldhosting.com!peer02.iad!feed-me.highwinds-media.com!news.highwinds-media.com!feeder.usenetexpress.com!tr3.iad1.usenetexpress.com!69.80.99.26.MISMATCH!Xl.tags.giganews.com!local-2.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Tue, 31 Jan 2023 19:37:02 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0g5mOpTpceZSLeVWcTUTj/rDf9yN445sJ8GtLM23K/I=; b=nceiQIvfx/fz +HpkKsIYwtkmrrhVDJCHzXtgtUGbCEC0ZqFZKl4ZYcCyqXCmJvcZl1dzvhuO4uws0hMOd6DSxtW9Z q1yk86o2k1RZHYJ8pVUwjJUJsjpkgzrPKcU78Qa1oMLesskMi+Iz3kDQ3Kjc5sfhM24oTM7oBC5Qk PQobSs9IMgKH/ykjQTZzKZ/AsPK3TiEkVD+3XR1/dq//t+p3dt2yi1htxWbAcOMrtGRtUKG/hecEw IZRRYF0PT5enE921OgGn/NtFUMk4Mm3tMKoaEju6CaF0u4N4x+la0hoCmuUV7d4i9fur3Y35fAzQM QBAQ8+Z7SwWlm3u93vhPxQ==;
Date: Tue, 31 Jan 2023 21:33:41 +0200
Message-Id: <83k0121otm.fsf@gnu.org>
From: djg...@delorie.com (Eli Zaretskii (eliz@gnu.org) [via djgpp@delorie.com])
To: djgpp@delorie.com
In-Reply-To: <CAA2C=vDu4Tgv8L9QYCVVaSJHEF5ArsH0BW8tPiOgTq4UvNnzcA@mail.gmail.com> (djgpp@delorie.com)
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com> <835ycn529o.fsf@gnu.org> <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com> <CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ@mail.gmail.com> <CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w@mail.gmail.com> <CAA2C=vAQKDYihM7EeYDKSsq0wSqds69xd47oWG=H=SGrKBGTsg@mail.gmail.com> <83leli1r3c.fsf@gnu.org> <CAA2C=vDu4Tgv8L9QYCVVaSJHEF5ArsH0BW8tPiOgTq4UvNnzcA@mail.gmail.com>
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 9
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-klCpCQI50xXX3+oO9zs/lkcFlYud0U3ThrpvC87ZnHFLG8Hfc0QM4tlhoVD3DcndTHMvs/2mipZV2RH!7ma9xGrf3fxQ+ffzLAw3fQ0yhNCFzQD+bHBgcws+R9AE
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
X-Received-Bytes: 2858
 by: Eli Zaretskii (eliz@ - Tue, 31 Jan 2023 19:33 UTC

> From: "Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]" <djgpp@delorie.com>
> Date: Tue, 31 Jan 2023 22:10:28 +0300
>
> > I'd say do this only under the verbose operation, i.e. optionally.
>
> i.e. error out only in verbose mode, which _can_ lead to problems?
> I' suggest inventing a new switch like --nomissing, what do you think?

SGTM.

Re: [PATCH] dxe3gen: add support for using an exports file.

<CAA2C=vBRD9ZXLObw=3PSMSuxNXnmenKQnD2DY=cyXEyhBcs52w@mail.gmail.com>

 copy mid

https://www.novabbs.com/devel/article-flat.php?id=330&group=comp.os.msdos.djgpp#330

 copy link   Newsgroups: comp.os.msdos.djgpp
Path: i2pn2.org!i2pn.org!usenet.blueworldhosting.com!feed1.usenet.blueworldhosting.com!peer03.iad!feed-me.highwinds-media.com!news.highwinds-media.com!feeder.usenetexpress.com!tr1.iad1.usenetexpress.com!69.80.99.26.MISMATCH!Xl.tags.giganews.com!local-2.nntp.ord.giganews.com!news.giganews.com.POSTED!not-for-mail
NNTP-Posting-Date: Tue, 31 Jan 2023 20:19:29 +0000
X-Authentication-Warning: delorie.com: mail set sender to djgpp-bounces using -f
X-Recipient: djgpp@delorie.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=CYdKlZT783BvMoGlUIt6WmegwQir/pwL/jbfoe/p1BY=; b=V0i0uOQzFJOzLNGhHZlVde+huE+q/bw6vVL+gLYHRWUAFXP34UX2LKYxJwle2FpBGx V/qmvlFETPEihxs8Bh2AVO6VnE1yw1VcJMM907e1+sLIW6FWf0TiM3l+3SqIKDhw5mgx rglNxcPS9yTjdHTxvU50QFvE0AQoU2f+s5kLgZBu6+8oQMZf8LWWN4Mu6HeQxzY7rsCG b1kYPGKWwsokpD5ErbQUve82WQe1CeW/VzSmN1KM3Xs72B3m/+cc3oX++itrYEIs3ne5 kTQSuSZuNJxu+v5XdIzi+a3PYn3Gi0sMMxcA1gIyayW1W3ApnFKHg2HCju7yihVeLMhE HQ9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CYdKlZT783BvMoGlUIt6WmegwQir/pwL/jbfoe/p1BY=; b=JNH6eDvef/pd5+gKYKfqgOyNFiFwobLPVEFkGaTw7o4jsP1NaWcPwJ33dyCi/Pm9+O 4TK0CSU30ro730QL/y2S3cI4frKcAMrX3Cs1l87JFP8bD0TA3Gx8w2i0ZSpLarEJdv1C pgk5B1NZ3CDqeHFMqRDJ+nT6ELiKhva0mWUNOfQnteE1jmCMLwHi3x10Cgh1dSlcjqM/ tiM5FvUyBx4SOxzUYtP4yLJatPU9O1G9CO4DLYQl7QfrZu5nFqF8vz+/IIw5WM44LH5o GmNam4UkwzNur/WyS0GrOsGF3dGt2gxCIYbIYS6LScl+bqA9N3ZCEvDb+GnCy+ZGDxX/ mJOQ==
X-Gm-Message-State: AO0yUKUkfYn/rbmvTMWMg2i3yjG0KKW/YNzryHyuJ0M31xITwsAGCc1C 58ry4AjIy7oedwxr11vJGwBe0nob1k8ETT9eDUehhjM9
X-Google-Smtp-Source: AK7set8U/KMHTUVsbH3ssmyXYOuqYf5akl83vRthttwRBHznPWS8LcZ0hul9NjRnMHXpd2S3DPzYdVBzyjzpJxLhmfA=
X-Received: by 2002:adf:f749:0:b0:2bc:7d91:f00 with SMTP id z9-20020adff749000000b002bc7d910f00mr6175wrp.68.1675196175869; Tue, 31 Jan 2023 12:16:15 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <83k0121otm.fsf@gnu.org>
References: <CAA2C=vCcrB4r7Z_1zOC+dvQnLiQjhp_zbhhuqJ7RQpQnrLuwMQ@mail.gmail.com> <835ycn529o.fsf@gnu.org> <CAA2C=vCP=M-r5Fb6YU5gpOqxHmk-rRXJLMSG8vieB84fE8ZAPA@mail.gmail.com> <CAA2C=vD8V=rpNwvuC+1Mj6GjNjyfByWVND8eiuOkF6R7ECYVvQ@mail.gmail.com> <CAA2C=vCMFJmBv6P_dAiDCRzCCn=gNZpjdPcfWH=e3QtR6NTi+w@mail.gmail.com> <CAA2C=vAQKDYihM7EeYDKSsq0wSqds69xd47oWG=H=SGrKBGTsg@mail.gmail.com> <83leli1r3c.fsf@gnu.org> <CAA2C=vDu4Tgv8L9QYCVVaSJHEF5ArsH0BW8tPiOgTq4UvNnzcA@mail.gmail.com> <83k0121otm.fsf@gnu.org>
From: djg...@delorie.com (Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com])
Date: Tue, 31 Jan 2023 23:16:15 +0300
Message-ID: <CAA2C=vBRD9ZXLObw=3PSMSuxNXnmenKQnD2DY=cyXEyhBcs52w@mail.gmail.com>
Subject: Re: [PATCH] dxe3gen: add support for using an exports file.
To: djgpp@delorie.com
Content-Type: text/plain; charset="UTF-8"
Reply-To: djgpp@delorie.com
Errors-To: nobody@delorie.com
X-Mailing-List: djgpp@delorie.com
X-Unsubscribes-To: listserv@delorie.com
Precedence: bulk
Newsgroups: comp.os.msdos.djgpp
Organization: None provided
DJ-Gateway: from mailing list djgpp@delorie.com
Lines: 20
X-Usenet-Provider: http://www.giganews.com
X-Trace: sv3-N8nU+eHlaIO7/Chu/OwofcsCUicqfGwH5BcJy4R+qEqELhqGVK7g9rjlV3gF1NJ/wrgRodpuZAAqdp1!9w/DixrnnIg2NJGXkO5rjhHE2GCeYzLHqoTd/4GcNnvn7THhQIM60wIpdn4OfcQNPChuMLRqIQs1!rsyayRjFD/nq6YOMgB9VGGluEMw=
X-Complaints-To: abuse@giganews.com
X-DMCA-Notifications: http://www.giganews.com/info/dmca.html
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
X-Received-Bytes: 4442
 by: Ozkan Sezer (sezeroz - Tue, 31 Jan 2023 20:16 UTC

On 1/31/23, Eli Zaretskii (eliz@gnu.org) [via djgpp@delorie.com]
<djgpp@delorie.com> wrote:
>> From: "Ozkan Sezer (sezeroz@gmail.com) [via djgpp@delorie.com]"
>> <djgpp@delorie.com>
>> Date: Tue, 31 Jan 2023 22:10:28 +0300
>>
>> > I'd say do this only under the verbose operation, i.e. optionally.
>>
>> i.e. error out only in verbose mode, which _can_ lead to problems?
>> I' suggest inventing a new switch like --nomissing, what do you think?
>
> SGTM.
>

OK, the patch is applied to cvs as r1.28:
https://www.delorie.com/bin/cvsweb.cgi/djgpp/src/dxe/dxe3gen.c
https://www.delorie.com/bin/cvsweb.cgi/djgpp/src/dxe/dxe3gen.c.diff?r1=1.27&r2=1.28

Documentation and 2.06 changelog updates are TODO (unless someone beats
me to it.)

1
server_pubkey.txt

rocksolid light 0.9.7
clearnet tor