Rocksolid Light

Welcome to novaBBS (click a section below)

mail  files  register  newsreader  groups  login

Message-ID:  

Prototype designs always work. -- Don Vonada


devel / comp.protocols.dicom / Handling of unmet Type 1C attribute

SubjectAuthor
* Handling of unmet Type 1C attributemadMorty
`- Handling of unmet Type 1C attributeMarkus Sabin

1
Handling of unmet Type 1C attribute

<225d69f7-1046-4906-aa21-a47d3f448014n@googlegroups.com>

  copy mid

https://www.novabbs.com/devel/article-flat.php?id=10307&group=comp.protocols.dicom#10307

  copy link   Newsgroups: comp.protocols.dicom
X-Received: by 2002:a05:622a:1801:: with SMTP id t1mr4015270qtc.638.1644483147422;
Thu, 10 Feb 2022 00:52:27 -0800 (PST)
X-Received: by 2002:a05:620a:bc7:: with SMTP id s7mr3279616qki.424.1644483147262;
Thu, 10 Feb 2022 00:52:27 -0800 (PST)
Path: i2pn2.org!i2pn.org!weretis.net!feeder8.news.weretis.net!proxad.net!feeder1-2.proxad.net!209.85.160.216.MISMATCH!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.protocols.dicom
Date: Thu, 10 Feb 2022 00:52:27 -0800 (PST)
Injection-Info: google-groups.googlegroups.com; posting-host=2003:d7:ff01:3d00:7cdd:d512:6cc4:3d05;
posting-account=JEyPZwoAAADgvqXlfDn3_bdujWVbq4jy
NNTP-Posting-Host: 2003:d7:ff01:3d00:7cdd:d512:6cc4:3d05
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <225d69f7-1046-4906-aa21-a47d3f448014n@googlegroups.com>
Subject: Handling of unmet Type 1C attribute
From: madmorty...@gmail.com (madMorty)
Injection-Date: Thu, 10 Feb 2022 08:52:27 +0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
 by: madMorty - Thu, 10 Feb 2022 08:52 UTC

Hi all,
so I was wondering what the general opinion is on handling Type 1C attributes in case their condition are not met.

Talking for example the PixelAspectRatio (0028,0034) considering an VL Endoscopic Image IOD: So when I know that my images/videos alsways have fixed PAR of 1:1, what would the right choice be:

1. Do not add the attribute to the SOP instance (or remove it)
2. Leave it within SOP instance with Zero Length value
3. Just set it with a value of "1\\1" anyhow

Considering "When the specified conditions are not met, Type 1C elements shall not be included in the Data Set." - from 7.4.2 Type 1C Conditional Data Elements, I would conclude that option (1.) is the correct one and that the attribute should not be included within the dataset at all. But how would you rate the other two options, would you say that in this case are generell wrong/bad practice or could they be fine too?

Kind regards,
Morty

Re: Handling of unmet Type 1C attribute

<b8f223be-ba9d-4d9f-a5ea-43819ccbce3cn@googlegroups.com>

  copy mid

https://www.novabbs.com/devel/article-flat.php?id=10309&group=comp.protocols.dicom#10309

  copy link   Newsgroups: comp.protocols.dicom
X-Received: by 2002:a05:6214:29c8:: with SMTP id gh8mr4579576qvb.126.1644488915004;
Thu, 10 Feb 2022 02:28:35 -0800 (PST)
X-Received: by 2002:a05:6214:2aa2:: with SMTP id js2mr4439839qvb.44.1644488914748;
Thu, 10 Feb 2022 02:28:34 -0800 (PST)
Path: i2pn2.org!i2pn.org!weretis.net!feeder6.news.weretis.net!1.us.feeder.erje.net!feeder.erje.net!border1.nntp.dca1.giganews.com!nntp.giganews.com!news-out.google.com!nntp.google.com!postnews.google.com!google-groups.googlegroups.com!not-for-mail
Newsgroups: comp.protocols.dicom
Date: Thu, 10 Feb 2022 02:28:34 -0800 (PST)
In-Reply-To: <225d69f7-1046-4906-aa21-a47d3f448014n@googlegroups.com>
Injection-Info: google-groups.googlegroups.com; posting-host=212.204.96.130; posting-account=FpWjmwoAAADouxZodjPwb9TZUXzY1wOz
NNTP-Posting-Host: 212.204.96.130
References: <225d69f7-1046-4906-aa21-a47d3f448014n@googlegroups.com>
User-Agent: G2/1.0
MIME-Version: 1.0
Message-ID: <b8f223be-ba9d-4d9f-a5ea-43819ccbce3cn@googlegroups.com>
Subject: Re: Handling of unmet Type 1C attribute
From: markussa...@gmail.com (Markus Sabin)
Injection-Date: Thu, 10 Feb 2022 10:28:34 +0000
Content-Type: text/plain; charset="UTF-8"
Lines: 6
 by: Markus Sabin - Thu, 10 Feb 2022 10:28 UTC

You actually caught the appropriate passage in the standard and "shall not be included" is to be taken literally - you would violate the standard by including it.
Where it is left to the implementor's choice to include it although the condition is not met, the attribute description in the module table clearly states that by extending the condition with the phrase "may be present otherwise".

So ((1C) AND (NOT "may be present otherwise")) = don't include it.

I think that the second option is the worst because this is a very clear standard violation - 1C attributes must never have zero length values.
Option 3 would probably not cause any trouble, but this does change the fact that it is incorrect.

1
server_pubkey.txt

rocksolid light 0.9.81
clearnet tor